felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sten Roger Sandvik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-5053) IllegalArgumentException when forwarding request
Date Thu, 08 Oct 2015 18:45:28 GMT

    [ https://issues.apache.org/jira/browse/FELIX-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14949134#comment-14949134

Sten Roger Sandvik commented on FELIX-5053:

Sorry, did not notice that. Probably the best thing for now is to ignore any exceptions from
the "getWriter().close()" operation?

> IllegalArgumentException when forwarding request
> ------------------------------------------------
>                 Key: FELIX-5053
>                 URL: https://issues.apache.org/jira/browse/FELIX-5053
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http.base-3.0.0
>            Reporter: Sten Roger Sandvik
>            Assignee: Sten Roger Sandvik
>             Fix For: http.base-3.0.2
> It seems to be a problem with forwarding requests in certain cases. I have the following
> * Servlet A forwards the request to Servlet 2 (using RequestDispatcher).
> * Servlet B writes to the response using an output stream (HttpServletResponse.getOutputStream()).
> When this happens I get an IllegalStateException from Jetty that basically saying that
the Writer cannot be closed since I have already used an OutputStream.
> The code that I think is wrong (or possibly not robust enough) is in RequestDispatcherImp
line 84. 
> {code}
> if (!request.isAsyncStarted())
> {
>   response.flushBuffer();
>   response.getWriter().close();
> }
> {code}
> The line that causes trouble is:
> {code}
> response.getWriter().close();
> {code}
> We should probably check if we can actually close this writer or just ignore the potential
> In my setup I have one servlet that writes to OutputStream using HttpServletResponse.getOutputStream().
Then I have another servlet that forwards the request to the first servlet. 

This message was sent by Atlassian JIRA

View raw message