felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4923) SslFilterResponse doesn 't take in account ssl-forward.header property
Date Fri, 02 Oct 2015 07:27:27 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940851#comment-14940851

Carsten Ziegeler commented on FELIX-4923:

[~asanso] If I understand the code correctly, X-Forwaded-SSL is checked to see whether the
filter should run at all, and then the harded headers are used to get the protocol and the
port. Not sure if that makes sense or not. In any case, care to make a patch?

> SslFilterResponse doesn 't take in account ssl-forward.header property
> ----------------------------------------------------------------------
>                 Key: FELIX-4923
>                 URL: https://issues.apache.org/jira/browse/FELIX-4923
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>            Reporter: Antonio Sanso
>            Priority: Minor
> {{SslFilterResponse}} doesn 't take in account {{ssl-forward}}.header property.
> Indeed the {{SslFilterResponse}} constructor hardcodes {{HDR_X_FORWARDED_PROTO}}.
> {code}
> ...
> request.getHeader(HDR_X_FORWARDED_PROTO);
> ...
> {code}
> the  {{ssl-forward}} osgin configuration should be taken in account IMHO. The default
is even different than {{HDR_X_FORWARDED_PROTO}} indeed is rather {{X-Forwarded-SSL}}

This message was sent by Atlassian JIRA

View raw message