felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carsten Ziegeler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4945) Escaped folder names makes ConfigAdmin incompatible and factory configs not always work
Date Mon, 06 Jul 2015 22:09:04 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615752#comment-14615752

Carsten Ziegeler commented on FELIX-4945:

[~balazs.zsoldos] A patch is definitely welcome.
I'm not so sure about handling the folder names the same on every operating system. I see
the reason behind it. If we do this, it must be compatible to the current way, which means
on non windows systems the old configs need to be read correctly and maybe then converted?

> Escaped folder names makes ConfigAdmin incompatible and factory configs not always work
> ---------------------------------------------------------------------------------------
>                 Key: FELIX-4945
>                 URL: https://issues.apache.org/jira/browse/FELIX-4945
>             Project: Felix
>          Issue Type: Bug
>          Components: Configuration Admin
>    Affects Versions: configadmin-1.8.6
>            Reporter: Balazs Zsoldos
> The fix of FELIX-4302 raises other issues:
>  - Old configurations that start with reserved names, are not read and components are
not instantiated
>  - The same configurations are not working on windows and other operating systems anymore.
Till now, we could copy the configuration folder between computers with different operating
system and it worked pretty well
>  - Strangely, factory.config files from old configurations were found, but the actual
configuration files were not
> This issues come from the fix of FELIX-4302.
> I would suggest that instead of
>  - having a Set winDevNames in FilePersist and
>  - callng winDevNames.equals(dir.substring(0, 3))
> create a separate function like isReservedName and handle the different names separately.
E.g.: directory names starting with "com" should be escaped only if there is a number afterwards
and nothing else.
> Handle reserved names in the same way on every operating system!!! Now the  configuration
that works on windows, will not work on linux (if we simply copy the configuration folders
to another system).

This message was sent by Atlassian JIRA

View raw message