Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 04A8B18FB7 for ; Mon, 25 May 2015 10:28:34 +0000 (UTC) Received: (qmail 95158 invoked by uid 500); 25 May 2015 10:28:18 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 95091 invoked by uid 500); 25 May 2015 10:28:18 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 94757 invoked by uid 99); 25 May 2015 10:28:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 May 2015 10:28:17 +0000 Date: Mon, 25 May 2015 10:28:17 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (FELIX-4860) Revisit HandlerRegistry implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-4860. ------------------------------------- Resolution: Fixed The servlet registry now uses a sorted data structure, with the potentially highest matching servlet first. As soon as a matching servlet is found, this can be used, no need to iterate over all servlets anymore. With this I think we have improved the registry implementations; i guess there is always room for improvement, but we should create more specific issues once we hit sem. > Revisit HandlerRegistry implementation > -------------------------------------- > > Key: FELIX-4860 > URL: https://issues.apache.org/jira/browse/FELIX-4860 > Project: Felix > Issue Type: Sub-task > Components: HTTP Service > Reporter: Thomas Baier > Assignee: Carsten Ziegeler > Fix For: http.base-3.0.0 > > > The implementation of the HandlerRegistry class needs to be revisited. There is quite some code duplication between the code for the servlet handler registrations and error pages/filter registrations. Also it might be worth checking if the current division into a servlet handler registry and a per context registry is the best solution, also with FELIX-4779 in mind. -- This message was sent by Atlassian JIRA (v6.3.4#6332)