Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6EC8017F44 for ; Fri, 17 Apr 2015 20:26:59 +0000 (UTC) Received: (qmail 94532 invoked by uid 500); 17 Apr 2015 20:26:59 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 94460 invoked by uid 500); 17 Apr 2015 20:26:59 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 94444 invoked by uid 99); 17 Apr 2015 20:26:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Apr 2015 20:26:59 +0000 Date: Fri, 17 Apr 2015 20:26:59 +0000 (UTC) From: "Thomas Watson (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-4656) Improve memory usage and speed of the resolver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14500601#comment-14500601 ] Thomas Watson commented on FELIX-4656: -------------------------------------- I agree that a release should be done with the current code. Other issues I raised should be done in another jira. I suggest waiting until we have proof of another performance issue or proof that valid solutions are being discarded without being processed. > Improve memory usage and speed of the resolver > ---------------------------------------------- > > Key: FELIX-4656 > URL: https://issues.apache.org/jira/browse/FELIX-4656 > Project: Felix > Issue Type: Improvement > Components: Resolver > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Fix For: resolver-1.2.0 > > Attachments: FELIX-4656.patch > > > During big resolutions (> 100 bundles), the memory consumption can become very huge, mostly by keeping a lot of copies of the Candidates object. > I want to lower the memory requirements of the resolver without touching the algorithm at all (which would be a different improvement). > This can be done by using : > * lower memory intensive collections > * do smart copies of those collections (where they would only actually copy the data when modify) > The second item is slightly more difficult to achieve, as the maps in the Candidate objects contains Set and List, which would mean that those must be copied too. So it could actually be complementary, if achievable. > For the first one, the HashMap and HashSet are very memory intensive. I'll introduce two new collections which will lower the requirements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)