felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4848) Split ResolverImpl
Date Thu, 09 Apr 2015 18:07:12 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487790#comment-14487790

Richard S. Hall commented on FELIX-4848:

I am always humored by such rules (e.g., a file shouldn't be over X many lines, etc.)...as
always, it just depends. I don't see how distributing complex code over multiple files makes
it any more tractable for someone than having those same details in a single file. Just an

> Split ResolverImpl
> ------------------
>                 Key: FELIX-4848
>                 URL: https://issues.apache.org/jira/browse/FELIX-4848
>             Project: Felix
>          Issue Type: Improvement
>          Components: Resolver
>    Affects Versions: resolver-1.0.0
>            Reporter: Christian Schneider
>             Fix For: resolver-1.2.0
> ResolverImpl currently contains about 2300 lines of code. That is way too big for a single
> I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency
methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.
> Both would share all of the inner classes of ResolverImpl but nothing else. 
> So I think i would make sense to move these inner classes to separate files.
> These changes should nicely split the classes into 
> ResolverImpl : 1400 lines
> ConsistencyCheck : 600 lines

This message was sent by Atlassian JIRA

View raw message