Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BA5617BE3 for ; Mon, 2 Mar 2015 17:24:11 +0000 (UTC) Received: (qmail 41037 invoked by uid 500); 2 Mar 2015 17:24:04 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 40886 invoked by uid 500); 2 Mar 2015 17:24:04 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 40610 invoked by uid 99); 2 Mar 2015 17:24:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 17:24:04 +0000 Date: Mon, 2 Mar 2015 17:24:04 +0000 (UTC) From: "Guillaume Nodet (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (FELIX-4810) Cache WeakZipFile#entries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved FELIX-4810. ------------------------------------ Resolution: Fixed Fixed with http://svn.apache.org/viewvc?view=revision&revision=1663368 > Cache WeakZipFile#entries > ------------------------- > > Key: FELIX-4810 > URL: https://issues.apache.org/jira/browse/FELIX-4810 > Project: Felix > Issue Type: Improvement > Components: Framework > Reporter: Guillaume Nodet > Assignee: Guillaume Nodet > Fix For: framework-4.6.1 > > Attachments: FELIX-4810.patch > > > The WeakZipFile#entries() method is used in several places when there's a need to iterate through bundle resources. > That can happen quite a lot of times if there are multiple extenders. > Caching this value would allow: > * avoid scanning all bundles multiple times, especially when they are resolved / started > * given it mostly happen when the bundle is resolved or started, using a SoftReference makes sense to not consume memory while still providing a good caching behaviour -- This message was sent by Atlassian JIRA (v6.3.4#6332)