felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Watson (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FELIX-4762) OutOfMemoryError (Java Heap Space) when resolving bundles
Date Thu, 15 Jan 2015 17:08:34 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278940#comment-14278940
] 

Thomas Watson edited comment on FELIX-4762 at 1/15/15 5:07 PM:
---------------------------------------------------------------

I have been reviewing this fix on the Equinox side in https://bugs.eclipse.org/bugs/show_bug.cgi?id=457118

In order to trigger the code I had to have a dependency tree like the following and I had
to use re-export for each level of the dependency:
{noformat}
       +-->C--+
A-->B--+      +-->E
       +-->D--+
{noformat}
Where :
 B re-exports C and D
 C re-exports E
 D re-exports E

In this scenario I would see duplicate blames for package E with the blamed requirement A->B

The fix looks good to me, but the variable names mergeExportedPackagesCycles and mergeExportedPackagesCyclesList
are misleading.  Perhaps a name like visitedRequiredBundlesMap and visitedRequiredBundles
for the list?


was (Author: tjwatson):
I have been reviewing this fix on the Equinox side in https://bugs.eclipse.org/bugs/show_bug.cgi?id=457118

In order to trigger the code I had to have a dependency tree like the following and I had
to use re-export for each level of the dependency:

           +-->C--+
A-->B--+         +-->E
           +-->D--+

Where :
 B re-exports C and D
 C re-exports E
 D re-exports E

In this scenario I would see duplicate blames for package E with the blamed requirement A->B

The fix looks good to me, but the variable names mergeExportedPackagesCycles and mergeExportedPackagesCyclesList
are misleading.  Perhaps a name like visitedRequiredBundlesMap and visitedRequiredBundles
for the list?

>  OutOfMemoryError (Java Heap Space) when resolving bundles 
> -----------------------------------------------------------
>
>                 Key: FELIX-4762
>                 URL: https://issues.apache.org/jira/browse/FELIX-4762
>             Project: Felix
>          Issue Type: Bug
>          Components: Resolver
>         Environment: Usage of Felix resolver as part of Eclipse Equinox
>            Reporter: Matthieu Helleboid
>            Priority: Critical
>         Attachments: avoidMergeDuplicateExportedPackages.patch
>
>
> When trying to start Capella (https://polarsys.org/capella/) we encounter OutOfMemoryError
(please see the stacktrace below). It seems that there is too many blames objects generated.
> The original bug is https://bugs.eclipse.org/bugs/show_bug.cgi?id=457118
> A quick workaround is proposed here https://git.eclipse.org/r/#/c/39271/
> This workaround helps to avoid OOMError, but the resolution is still very
> slow



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message