Return-Path: 
 <dev-return-40511-apmail-felix-dev-archive=felix.apache.org@felix.apache.org>
X-Original-To: apmail-felix-dev-archive@www.apache.org
Delivered-To: apmail-felix-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6A43317455
	for <apmail-felix-dev-archive@www.apache.org>;
 Wed, 12 Nov 2014 01:04:08 +0000 (UTC)
Received: (qmail 8285 invoked by uid 500); 12 Nov 2014 01:04:08 -0000
Delivered-To: apmail-felix-dev-archive@felix.apache.org
Received: (qmail 8211 invoked by uid 500); 12 Nov 2014 01:04:07 -0000
Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@felix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@felix.apache.org>
List-Post: <mailto:dev@felix.apache.org>
List-Id: <dev.felix.apache.org>
Reply-To: dev@felix.apache.org
Delivered-To: mailing list dev@felix.apache.org
Received: (qmail 8199 invoked by uid 99); 12 Nov 2014 01:04:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 01:04:07 +0000
Date: Wed, 12 Nov 2014 01:04:07 +0000 (UTC)
From: "Carsten Ziegeler (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Message-ID: <JIRA.12753907.1415445951000.475300.1415754247827@Atlassian.JIRA>
In-Reply-To: <JIRA.12753907.1415445951000@Atlassian.JIRA>
References: <JIRA.12753907.1415445951000@Atlassian.JIRA>
 <JIRA.12753907.1415445951857@arcas>
Subject: [jira] [Commented] (FELIX-4686) If component is declared with 1.3
 NS and ds.factory.enabled = true, validation error occors
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FELIX-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207456#comment-14207456 ] 

Carsten Ziegeler commented on FELIX-4686:
-----------------------------------------

[~djencks] Rethinking the whole story, for compatibility sake we should leave the switch (ds.factory.enabled) in.
So basically what you're saying is to always switch of ds.factory.enabled and change the old components that use that. However, you don't know which component is actually using this, right? If you have hundreds of bundles, you would need to rewrap all those bundles. (Or maybe I'm missing something).
Where on the other hand, we could simply say, if you're using the 1.3 NS, the ds.factory.enabled flag has no influence on your component anymore - which my patch does. And this simply ensures, old bundles work as is, new bundles work as expected as well.

> If component is declared with 1.3 NS and ds.factory.enabled = true, validation error occors
> -------------------------------------------------------------------------------------------
>
>                 Key: FELIX-4686
>                 URL: https://issues.apache.org/jira/browse/FELIX-4686
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: scr-2.0.0
>
>
> For example the following component xml leads to a validation error:
> "Configuration of component factory instances through config admin factory pids supported only through the 1.2 namespace"
> <components xmlns:scr="http://www.osgi.org/xmlns/scr/v1.3.0">
>     <scr:component name="org.apache.sling.sample.slingshot.impl.SetupService" activate="activate" deactivate="deactivate">
>         <implementation class="org.apache.sling.sample.slingshot.impl.SetupService"/>
>         <property name="service.vendor" value="The Apache Software Foundation"/>
>         <property name="service.pid" value="org.apache.sling.sample.slingshot.impl.SetupService"/>
>     </scr:component>
> </components>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)