felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4631) [DS][R6/RFC212] Implement field injection
Date Sat, 08 Nov 2014 21:19:33 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203597#comment-14203597
] 

David Jencks commented on FELIX-4631:
-------------------------------------

It's a little hard to tell since there are so many whitespace changes but I think your approach
should be fine.  I don't understand why you want to introduce another package, impl.helper.impl
seems really redundant to me.  Would you be willing to keep everything in impl.helper?

Why is ReferenceMethod<BindParameters> parameterized by <BindParameters>?  I don't
see any other use.  Perhaps adding the parameterization when we have a concrete use for it
would be reasonable?

> [DS][R6/RFC212] Implement field injection
> -----------------------------------------
>
>                 Key: FELIX-4631
>                 URL: https://issues.apache.org/jira/browse/FELIX-4631
>             Project: Felix
>          Issue Type: Task
>          Components: Declarative Services (SCR)
>            Reporter: Carsten Ziegeler
>             Fix For: scr-2.0.0
>
>         Attachments: fieldinjection.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message