felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Sanso (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4664) [SSLFilter] Support for pre-3.0 Servlet API
Date Mon, 06 Oct 2014 08:43:33 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160103#comment-14160103
] 

Antonio Sanso commented on FELIX-4664:
--------------------------------------

LGTM

> [SSLFilter] Support for pre-3.0 Servlet API
> -------------------------------------------
>
>                 Key: FELIX-4664
>                 URL: https://issues.apache.org/jira/browse/FELIX-4664
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-2.3.0, http-sslfilter-0.1.0
>            Reporter: Felix Meschberger
>         Attachments: FELIX-4664.patch
>
>
> The SSL Filter bundle currently inherits the Servlet API dependency from the parent project
which sets it to Servlet API 3.0. 
> Actually, the filter itself does not depend at all on Servlet API 3.0 and the dependency
should probably be fixed to a reduced version number -- maybe even the lowest version still
compiling...
> There is one caveat: unit tests currently use HttpServletResponse.getHeader method which
has been introduced with Servlet API 3.0. So the tests need to be tweaked.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message