felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Valentin Valchev (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3817) Form parameters might clash with configuration parameters
Date Fri, 17 Oct 2014 12:42:33 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175014#comment-14175014

Valentin Valchev commented on FELIX-3817:

IMHO the REST API should stay constant. If we say you 'apply' your data, you should never
say '$apply' my data.
It's the data, that should be changed.

But if we want to do it right, it's probably better to have the data (configuration properties)
serialized not as request parameters but POSTed as JSON body content. Unfortunately this will
completely break the compatibility.

> Form parameters might clash with configuration parameters
> ---------------------------------------------------------
>                 Key: FELIX-3817
>                 URL: https://issues.apache.org/jira/browse/FELIX-3817
>             Project: Felix
>          Issue Type: Bug
>          Components: Web Console
>    Affects Versions: webconsole-4.0.0
>            Reporter: Carsten Ziegeler
>             Fix For: webconsole-4.2.4
>         Attachments: webconsole-FELIX-3817.patch
> If a configuration has a property named "delete" or "propertylist" (and maybe there are
more) then this clashes with the form parameter names of the configuration web console plugin
and editing such a configuration is not possible.
> We should use more unique names, maybe namespaced somehow to reduce the potential of
a name clash

This message was sent by Atlassian JIRA

View raw message