Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD83511A20 for ; Wed, 3 Sep 2014 09:13:51 +0000 (UTC) Received: (qmail 22596 invoked by uid 500); 3 Sep 2014 09:13:51 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 22524 invoked by uid 500); 3 Sep 2014 09:13:51 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 22511 invoked by uid 99); 3 Sep 2014 09:13:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 09:13:51 +0000 Date: Wed, 3 Sep 2014 09:13:51 +0000 (UTC) From: "Benjamin Debeerst (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-4565) Occasional ArrayIndexOutOfBoundException in iPOJO's ProvidedServiceHandler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119675#comment-14119675 ] Benjamin Debeerst commented on FELIX-4565: ------------------------------------------ Is there a way to see the commits/diff that belonged to this fix? > Occasional ArrayIndexOutOfBoundException in iPOJO's ProvidedServiceHandler > -------------------------------------------------------------------------- > > Key: FELIX-4565 > URL: https://issues.apache.org/jira/browse/FELIX-4565 > Project: Felix > Issue Type: Bug > Components: iPOJO > Affects Versions: ipojo-runtime-1.11.2 > Environment: Karaf 2.3.3 / Windows 7 64 bit > Reporter: Benjamin Debeerst > Assignee: Clement Escoffier > Fix For: ipojo-runtime-1.12.1 > > > I have an iPOJO (1.11.2) component using the @ServiceController annotation to control the service publishing. Most of the time this works perfectly fine, but occasionally I get an ArrayIndexOutOfBoundsException. > {code} > java.lang.ArrayIndexOutOfBoundsException: 4 > at org.apache.felix.ipojo.handlers.providedservice.ProvidedServiceHandler.__M_onSet(ProvidedServiceHandler.java:416)[83:org.apache.felix.ipojo:1.11.2] > at org.apache.felix.ipojo.handlers.providedservice.ProvidedServiceHandler.onSet(ProvidedServiceHandler.java)[83:org.apache.felix.ipojo:1.11.2] > at org.apache.felix.ipojo.InstanceManager.onSet(InstanceManager.java:1401)[83:org.apache.felix.ipojo:1.11.2] > [..] (My own code following, where the service controller boolean is manipulated) > {code} > Unfortunately I cannot share the consumer code nor reproduce the problem. I looked into [iPOJOs code|http://grepcode.com/file/repo1.maven.org/maven2/org.apache.felix/org.apache.felix.ipojo/1.11.2/org/apache/felix/ipojo/handlers/providedservice/ProvidedServiceHandler.java#416] to see what's going on, and there we have: > {code} > for (int j = 0; j < svc.getProperties().length; j++) { Property prop = svc.getProperties()[j]; > [...] > } > {code} > Which looks like a proper race condition to me, if svc.getProperties() changes its value in the meantime because of missing synchronizations. I don't see any synchronizations there, but I also don't know if they would be appropriate in the first place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)