Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Received-SPF: pass (athena.apache.org: domain of 10527@liferay.com designates
 209.85.216.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <541AD180.6020302@ungoverned.org>
References: <541A8D08.4080707@ascert.com>
	<541AD180.6020302@ungoverned.org>
Date: Thu, 18 Sep 2014 08:45:43 -0400
Message-ID: 
 <CAMm6HcD-Ts8M7i1KeO9a97ka=v7Nsv0B1z7mUJuk7Fu1ijCCHQ@mail.gmail.com>
Subject: Re: Stream Closed issue loading bundles over HTTP
From: Raymond Auge <raymond.auge@liferay.com>
To: Apache Felix Developers <dev@felix.apache.org>
Content-Type: multipart/alternative; boundary=089e0153819ad8f9150503565ca4

--089e0153819ad8f9150503565ca4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

May I ask to see the stacktrace of the original error?

I want to correlate a strange jetty error from non-felix code against this
one because they seem eerily similar. (long shot)

- Ray

On Thu, Sep 18, 2014 at 8:35 AM, Richard S. Hall <heavy@ungoverned.org>
wrote:

> I guess the question to ask is what behavior is the correct behavior if
> there really is an exception on close? This patch will ignore every
> exception, not just ones that occurs because of a double close (although =
it
> seems to me a double close should be a no-op, not sure why it throws, but
> that is another issue).
>
> Does it make sense that every close exception is ignored and the user is
> never alerted? Granted, there isn't much we can do, but often such errors
> are better breaking things than just being ignored.
>
> -> richard
>
>
> On 9/18/14 03:43 , Rob Walker wrote:
>
>> Just wanted to check this one before I raise a JIRA, in case it's known
>> and/or already been fixed or being worked on.
>>
>> In one of our models we  provision our application over WebStart, which
>> causes bundles to be loaded over HTTP. Occasionally we get a Stream Clos=
ed
>> exception being thrown from the Jetty HTTP server (the server serving up
>> the code is also running under Felix).
>>
>> What seems to happen is a double close of the input stream - which throw=
s
>> an error. I've include the notes below from our developer who found this=
.
>>
>> It's a pretty simple mod to ignore the exception on second close
>> (highlighted red below) - assuming everyone is happy this is an ok appro=
ach.
>>
>> -- Rob
>>
>> =3D=3D=3D
>>
>> /It turns out the problem was arising when caching the VersaTest jar
>> files. Whilst they are coming across via WebStart ok, an error was being
>> thrown because the stream used to read them was being closed multiple ti=
mes
>> and at some point the close operation causes an exception that isn't cau=
ght
>> so stops the load.  This error occurs in Felix in the JarRevision class,=
 in
>> the initialize() method. I put a simple fix in that ignored the error on
>> close. So in the code below, a close on the input stream was being calle=
d
>> in the //BundleCache.copyStreamToFile(is, m_bundleFile)  and in the
>> bottom finally block (you can see below where I put in that disregarding
>> catch.  (Note, I suspect that also the input stream could be closed in t=
he
>> //((HttpURLConnection) conn).disconnect() //as well. But it is explicitl=
y
>> closed in the copyStreamToFile.)////
>> ///
>>
>>                 if (!byReference)
>>                 {
>>                     URLConnection conn =3D null;
>>                     try
>>                     {
>>                         if (is =3D=3D null)
>>                         {
>>                             // Do it the manual way to have a chance to
>>                             // set request properties such as proxy auth=
.
>>                             URL url =3D BundleCache.getSecureAction().
>> createURL(
>>                                 null, getLocation(), null);
>>                             conn =3D url.openConnection();
>>
>>                             // Support for http proxy authentication.
>>                             String auth =3D BundleCache.getSecureAction(=
)
>> .getSystemProperty("http.proxyAuth", null);
>>                             if ((auth !=3D null) && (auth.length() > 0))
>>                             {
>>                                 if ("http".equals(url.getProtocol()) ||
>> "https".equals(url.getProtocol()))
>>                                 {
>>                                     String base64 =3D
>> Util.base64Encode(auth);
>> conn.setRequestProperty(
>> "Proxy-Authorization", "Basic " + base64);
>>                                 }
>>                             }
>>                             is =3D BundleCache.getSecureAction()
>> .getURLConnectionInputStream(conn);
>>                         }
>>
>>                         // Save the bundle jar file.
>> BundleCache.copyStreamToFile(is, m_bundleFile);
>>                     }
>>                     finally
>>                     {
>>                         // This is a hack to fix an issue on Android,
>> where
>>                         // HttpURLConnections are not properly closed.
>> (FELIX-2728)
>>                         if ((conn !=3D null) && (conn instanceof
>> HttpURLConnection))
>>                         {
>>                             ((HttpURLConnection) conn).disconnect();
>>                         }
>>                     }
>>                 }
>>             }
>>         }
>>         finally
>>         {
>>             if (is !=3D null)
>>             {
>>                 try
>>                 {
>>                     is.close();
>>                 } catch (IOException ioe)
>>                 {
>>                     /*  Catch and disregard exception on close as could
>> already have been closed,
>>                         either in the disconnect or in the
>> copyStreamToProfile
>>                     */
>>
>>                 }
>>
>>             }
>>         }
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>


--=20
*Raymond Aug=C3=A9* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect
*Liferay, Inc.* <http://www.liferay.com> (@Liferay)

--089e0153819ad8f9150503565ca4--