felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Bosschaert (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4647) Incorrect check of the NO_LOCAL_RESOURCES flag in ResolverImpl:resolve()
Date Fri, 19 Sep 2014 14:10:34 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140617#comment-14140617
] 

David Bosschaert commented on FELIX-4647:
-----------------------------------------

As an aside, it would be nice if the repository could use the standalone resolver, which is
heavily tested in various contexts. I've created FELIX-4650 for that.

> Incorrect check of the NO_LOCAL_RESOURCES flag in ResolverImpl:resolve()
> ------------------------------------------------------------------------
>
>                 Key: FELIX-4647
>                 URL: https://issues.apache.org/jira/browse/FELIX-4647
>             Project: Felix
>          Issue Type: Bug
>          Components: Bundle Repository (OBR)
>    Affects Versions: bundlerepository-1.6.6
>            Reporter: Modestas Vainius
>
> Hello,
> if I understand correctly, the following code is wrong
> {code:title=ResolverImpl.java:227}
> if ((flags & NO_LOCAL_RESOURCES) == 0)
> {
>     m_requiredSet.removeAll(Arrays.asList(locals));
> }
> {code}
> {code:title=ResolverImpl.java:233}
> if ((flags & NO_LOCAL_RESOURCES) == 0)
> {
>     m_optionalSet.removeAll(Arrays.asList(locals));
> }
> {code}
> I believe, in both cases the conditional should be:
> {code}
> if ((flags & NO_LOCAL_RESOURCES) != 0)
> {code}
> Due to this bug I'm seeing some important bundles getting auto-uninstalled from ServiceMix
container when they are not supposed be. This breaks feature uninstall.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message