felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4525) Refactor the Framework to use the Resolver module
Date Wed, 10 Sep 2014 19:30:34 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128970#comment-14128970
] 

Richard S. Hall commented on FELIX-4525:
----------------------------------------

I looked at this briefly and it looks fairly reasonable. I think you can keep going forward
with it. Admittedly, I didn't look into it in much depth, so I'll try to look at it some more
to refresh my memory about the dynamic import stuff.

One nit, you change BundleRevisionImpl.toString() to be a fairly long string...I didn't look
in depth at where this was being used, but I want to think it was being used for diagnostic
output, which could make things a little verbose if so. We might want to check.

> Refactor the Framework to use the Resolver module
> -------------------------------------------------
>
>                 Key: FELIX-4525
>                 URL: https://issues.apache.org/jira/browse/FELIX-4525
>             Project: Felix
>          Issue Type: Task
>          Components: Framework
>    Affects Versions: framework-4.4.0
>            Reporter: David Bosschaert
>            Assignee: David Bosschaert
>             Fix For: framework-4.6.0
>
>
> Currently both the framework has a resolver implementation as well as the resolver module,
which has a separate resolver implementation. The resolver module originates from the framework,
but they are not the same any more.
> It would be good to refactor the framework to use the resolver implementation from the
resolver module so that there is no code duplication any more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message