felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carsten Ziegeler <cziege...@apache.org>
Subject Re: [HttpService - Whiteboard] Missing modifiedService() in AbstractTracker
Date Fri, 22 Aug 2014 16:16:43 GMT
Hi Dominique,

good catch - I think this is a bug - if a whiteboard service changes its
registration properties, this is right now ignored. And yes, I guess the
fix is to call the abstract modifiedService method
Could you please open an issue for this?


2014-08-21 15:54 GMT+02:00 Dominique Pfister <dpfister@adobe.com>:

> Hi,
> I noticed that in
> o.a.f.http.whiteboard.internal.tracker.AbstractTracker<T>, methods
> addingService() and removedService() call their super implementation and
> then invoke an abstract, subclass responsible override with generic type T.
> modifiedService(), however, calls the super implementation, only, although
> an abstract modifiedService() with argument type T is declared, but never
> used.
> Is this an oversight or did I miss something?
> Thanks
> Dominique

Carsten Ziegeler
Adobe Research Switzerland

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message