felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rob Walker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4528) Felix properties cannot be used in unsigned JNLP files
Date Tue, 10 Jun 2014 06:59:01 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026181#comment-14026181
] 

Rob Walker commented on FELIX-4528:
-----------------------------------

Ok - message received and understood, well do it in our launcher.

FWIW - I kinda agree that specific environments and OSs should have their special needs catered
for in specific launchers, or modules. I was just following how the code is now, where we
seem to have special handling cases (e.g. Android and GNU) dotted through the framework code.
It would be much tidier to have all these cases handled in dedicated launchers or modules,
but that only works if we have a project structure where we provide those modules. if not,
we either have a generic framework that needs custom code to actually run anywhere, or we
have custom handling cases dotted through the generic code as now. If we want to keep it pure,
great, let's do that - but it doesn't seem that way now to me.

Karl - not 100% sure that expansion idea will work. I think this case goes direct to System.getProperty,
and doesn't call through the property expansion code. I could be wrong though, I forget if
we expand and push to system properties at startup. I don't think we do though. The other
problem is that this property checking code happens in static initializers, which get called
on classloading, and hence quite possibly before areas such as property handling and expansion
are bootstrapped fully.

> Felix properties cannot be used in unsigned JNLP files
> ------------------------------------------------------
>
>                 Key: FELIX-4528
>                 URL: https://issues.apache.org/jira/browse/FELIX-4528
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>         Environment: java 7u45 and later
>            Reporter: Rob Walker
>            Assignee: Rob Walker
>            Priority: Minor
>         Attachments: sec_action.patch
>
>
> Unsigned JNLP files are required for most real world cases - especially those with dynamic
deployment needs where the host URL cannot be known  in advance.
> To use System properties in unsigned JNLP files  they must be prefixed with "jnlp." 
- which effectively renders all current Felix properties unusable.
> Attached is a patch with one implementation approach for this - a mod to SecureAction
to check for a "jnlp," version of a property before falling back to System properties or the
supplied default.
> An alternative would be additional init code in Felix or FelixConstants to test each
property that we wish to expose to JNLP files and push any non-null value into System properties.
This would be more transparent, but also more maintenance whenever new FelixConstants are
added.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message