felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "james strachan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4393) @Property should accept empty name values on fields
Date Tue, 04 Mar 2014 13:34:22 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919389#comment-13919389

james strachan commented on FELIX-4393:

Well, its pretty trivial to write a helper function (or in our case a helper service, Configurer)
to inject field values from a Map<String,String> :). It doesn't matter whether DS supports
it or not really; its more about using the annotations to generate the DS and MetaType XML

>  @Property should accept empty name values on fields 
> -----------------------------------------------------
>                 Key: FELIX-4393
>                 URL: https://issues.apache.org/jira/browse/FELIX-4393
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven SCR Plugin
>            Reporter: james strachan
>            Assignee: Carsten Ziegeler
>             Fix For: maven-scr-plugin 1.15.2, scr ant task 1.9.2, scr generator 1.8.4
> it'd be nice if @Property behaved like various other annotations (e.g. @Inject / @Resource)
so that if a name is not specified and @Property is specified on a field, then the name value
defaults to the field name.
> It looks like name is optional with a default of "" - so its just the maven scr plugin
which seems to barf if name is empty generating this kind of compile error:
> {code}
> @Property : Property name can not be empty.
> {code}
> It'd be nice if the name was optional; it makes the code more DRY and keeps things more
refactoring safe etc

This message was sent by Atlassian JIRA

View raw message