Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAC5610528 for ; Tue, 10 Dec 2013 01:22:08 +0000 (UTC) Received: (qmail 33209 invoked by uid 500); 10 Dec 2013 01:22:08 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 33128 invoked by uid 500); 10 Dec 2013 01:22:07 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 33109 invoked by uid 99); 10 Dec 2013 01:22:07 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Dec 2013 01:22:07 +0000 Date: Tue, 10 Dec 2013 01:22:07 +0000 (UTC) From: "David Jencks (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-4350) Component wrongly activated MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843797#comment-13843797 ] David Jencks commented on FELIX-4350: ------------------------------------- I committed a fix for this that I think is OK but exposes another problem. My fix adds a "deleted" field to RefPair and checks that a RefPair is not deleted before trying to bind it. So if a removedService event comes in before starting to open a dependency manager on an instance object, the ref pair will be marked deleted and binding wont happen, and if it comes in after the open starts the open latch should prevent anything happening until after the bind is complete. (rev 1549723) However, with this change I get a consistent NPE in Felix3680Test where the service tracker is calling removedService will a null tracking object. I think I introduced a bug in untrack in that a remove event may come in before initial is populated. Restoring the "if tracked object is null return" should fix this. (rev 1549728) Can you review this and look for problems? > Component wrongly activated > --------------------------- > > Key: FELIX-4350 > URL: https://issues.apache.org/jira/browse/FELIX-4350 > Project: Felix > Issue Type: Bug > Components: Declarative Services (SCR) > Reporter: Guillaume Nodet > Attachments: karaf.log > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)