felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-4350) Component wrongly activated
Date Tue, 10 Dec 2013 01:22:07 GMT

    [ https://issues.apache.org/jira/browse/FELIX-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843797#comment-13843797
] 

David Jencks commented on FELIX-4350:
-------------------------------------

I committed a fix for this that I think is OK but exposes another problem.  My fix adds a
"deleted" field to RefPair and checks that a RefPair is not deleted before trying to bind
it.  So if a removedService event comes in before starting to open a dependency manager on
an instance object, the ref pair will be marked deleted and binding wont happen, and if it
comes in after the open starts the open latch should prevent anything happening until after
the bind is complete. (rev 1549723)

However, with this change I get a consistent NPE in Felix3680Test where the service tracker
is calling removedService will a null tracking object.  I think I introduced a bug in untrack
in that a remove event may come in before initial is populated.  Restoring the "if tracked
object is null return" should fix this. (rev 1549728)

Can you review this and look for problems?

> Component wrongly activated
> ---------------------------
>
>                 Key: FELIX-4350
>                 URL: https://issues.apache.org/jira/browse/FELIX-4350
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>            Reporter: Guillaume Nodet
>         Attachments: karaf.log
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message