Return-Path: 
 <dev-return-37069-apmail-felix-dev-archive=felix.apache.org@felix.apache.org>
X-Original-To: apmail-felix-dev-archive@www.apache.org
Delivered-To: apmail-felix-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 84F431093F
	for <apmail-felix-dev-archive@www.apache.org>;
 Tue, 15 Oct 2013 23:55:42 +0000 (UTC)
Received: (qmail 82840 invoked by uid 500); 15 Oct 2013 23:55:42 -0000
Delivered-To: apmail-felix-dev-archive@felix.apache.org
Received: (qmail 82738 invoked by uid 500); 15 Oct 2013 23:55:42 -0000
Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@felix.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@felix.apache.org>
List-Post: <mailto:dev@felix.apache.org>
List-Id: <dev.felix.apache.org>
Reply-To: dev@felix.apache.org
Delivered-To: mailing list dev@felix.apache.org
Received: (qmail 82680 invoked by uid 99); 15 Oct 2013 23:55:42 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2013 23:55:42 +0000
Date: Tue, 15 Oct 2013 23:55:42 +0000 (UTC)
From: "David Jencks (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Message-ID: <JIRA.12668145.1378933929072.69420.1381881342160@arcas>
In-Reply-To: <JIRA.12668145.1378933929072@arcas>
References: <JIRA.12668145.1378933929072@arcas>
Subject: [jira] [Resolved] (FELIX-4224) [DS] Dependency manager can be
 active but not have m_bindMethods set
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/FELIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks resolved FELIX-4224.
---------------------------------

    Resolution: Fixed

m_bindMethods was made volatile in a commit for FELIX-4223

> [DS] Dependency manager can be active but not have m_bindMethods set
> --------------------------------------------------------------------
>
>                 Key: FELIX-4224
>                 URL: https://issues.apache.org/jira/browse/FELIX-4224
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.8.0
>
>
> We've seen an NPE from m_bindMethods being null in this code:
>         public void addedService( ServiceReference<T> serviceReference, RefPair<T> refPair, int trackingCount )
>         {
>             m_componentManager.log( LogService.LOG_DEBUG, "dm {0} tracking {1} MultipleDynamic added {2} (enter)", new Object[] {getName(), trackingCount, serviceReference}, null );
>         	boolean tracked = false;
>             if ( getPreviousRefMap().remove( serviceReference ) == null )
>             {
>                 if (isActive())
>                 {
>                     getServiceObject( m_bindMethods.getBind(), refPair );
> (DependencyManager.MultipleDynamicCustomizer, around line 314)
> After some investigation I can't see any way this can occur except from m_bindMethods not being volatile.  I'll see if this reoccurs after making it volatile.



--
This message was sent by Atlassian JIRA
(v6.1#6144)