Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23BE510872 for ; Mon, 30 Sep 2013 06:30:50 +0000 (UTC) Received: (qmail 82978 invoked by uid 500); 30 Sep 2013 06:30:44 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 82037 invoked by uid 500); 30 Sep 2013 06:30:33 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 81971 invoked by uid 99); 30 Sep 2013 06:30:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Sep 2013 06:30:26 +0000 Date: Mon, 30 Sep 2013 06:30:26 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FELIX-4249) Make the default error location 1,1 instead of 0,0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781623#comment-13781623 ] Carsten Ziegeler commented on FELIX-4249: ----------------------------------------- Thanks Robert, I've applied this patch - it would be great if we could have real line numbers. I briefly played around with asm and it seems it shouldn't be that hard to get line numbers for methods. If you have some idea how to easily get line numbers for all instructions this would be really great. > Make the default error location 1,1 instead of 0,0 > -------------------------------------------------- > > Key: FELIX-4249 > URL: https://issues.apache.org/jira/browse/FELIX-4249 > Project: Felix > Issue Type: Improvement > Components: Maven SCR Plugin > Affects Versions: scr generator 1.8.0 > Reporter: Robert Munteanu > Assignee: Carsten Ziegeler > Priority: Minor > Fix For: maven-scr-plugin 1.15.0, scr ant task 1.9.0, scr generator 1.8.2 > > Attachments: FELIX-4249-1.patch > > > The scr generator's error reporting places the errors by default at the 0,0 coordinates. In practice, this means that in Eclipse the error/warning is associated with the file and shown in the problems view but not in the editor. > To make this more visible, I suggest that we change the error location to 1,1, which places it in the first line of the file. Should we want to, we can extract line ( but not column ) information from ASM to place the warning closer to the source. -- This message was sent by Atlassian JIRA (v6.1#6144)