Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 577F110843 for ; Fri, 2 Aug 2013 07:31:54 +0000 (UTC) Received: (qmail 57512 invoked by uid 500); 2 Aug 2013 07:31:49 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 57457 invoked by uid 500); 2 Aug 2013 07:31:49 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 57444 invoked by uid 99); 2 Aug 2013 07:31:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2013 07:31:48 +0000 Date: Fri, 2 Aug 2013 07:31:48 +0000 (UTC) From: "Carsten Ziegeler (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (FELIX-4101) Create metatype.properties file when description and label are inlined MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed FELIX-4101. ----------------------------------- > Create metatype.properties file when description and label are inlined > ---------------------------------------------------------------------- > > Key: FELIX-4101 > URL: https://issues.apache.org/jira/browse/FELIX-4101 > Project: Felix > Issue Type: Improvement > Components: Maven SCR Plugin > Reporter: Carsten Ziegeler > Assignee: Carsten Ziegeler > Fix For: maven-scr-plugin 1.14.0, scr ant task 1.8.0, scr generator 1.8.0 > > > We advertise the SCR annotations with "single source development" = everything is in a single java source file, no need to edit any other file (like the DS xml descriptor). However as soon as you use metatype information this is not necessarily true, especially if you want to put the real values in a separate metatype.properties file. > This somehow breaks the ease of use promise and requires to keep the source code and the metatype properties in sync. > We could easily get away with this by always creating a metatype.properties file when information like label or description is inlined, e.g. > @Property(label = "Velocity", description="Set the velocity", name="velocity") will > create a metatype.properties file with > PID.velocity.name = Velocity > PID.velocity.description = Set the velocity > and a metatype XML with > > This would allow to add translations even if the information was inlined in the source code. > We could add a switch whether this should be enabled or not, default set to true. I think we need this switch just for the (rare?) case where within the same bundles some metatype is inlined while other metatype info is within a metatype.properties. - we could even handle this by merging a potentially existing props file with the generated. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira