Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
MIME-Version: 1.0
In-Reply-To: <E7442DB8-4FCB-4AD5-8783-E4859A2AF205@adobe.com>
References: <40B5B1C3-170D-48C5-B245-85FE3B8B592A@adobe.com>
	<CAKkCf4oPYX0ALF08a3C2urNQ-H_dzy-F--+EP-EAMeLzRJ_vPA@mail.gmail.com>
	<E7442DB8-4FCB-4AD5-8783-E4859A2AF205@adobe.com>
Date: Mon, 11 Mar 2013 14:26:44 +0100
Message-ID: 
 <CAKkCf4qAZhfB0WTbZSFyTFP2mEVXvsMK+payMLxpa39B_QtDCQ@mail.gmail.com>
Subject: Re: [InventoryPrinter] Finding methods by reflection
From: Carsten Ziegeler <cziegeler@apache.org>
To: dev@felix.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

2013/3/11 Felix Meschberger <fmeschbe@adobe.com>:
> Hi,
>
> Am 10.03.2013 um 19:59 schrieb Carsten Ziegeler:
>
>> Hi,
>>
>>> My opinion would be:
>>>
>>> (a) search the implementation class only
>>> (b) accept all method modifiers
>>> (c) document to prefer private
>>>
>>> Alternatively we could search the class hierarchy as is defined in sect=
ion 112.9.4 (Locating Component Methods) of the Declarative Services specif=
ication.
>>
>> I think the current implementation searches the hierarchy
>
> Yes and no ;-) The current implementation walks the hierarchy but it uses=
 the Class.getMethod method to find the method, which actually only returns=
 public methods. So walking the hierarchy is essentially useless.
>
Ah, right - yes the idea was that the method has to be public,
otherwise the service is not used, now I remember :)

Carsten

> Just using getDeclaredMethod is not fully correct, because you probably d=
on't want to use a private method from a super class or a package private m=
ethod from a super class in a different package. Which is why I also refer =
to the DS specification, which explains how to actually find and select met=
hods from superclasses.
>
>
>> - I don't
>> have a strong preference, but I think searching the hierarchy is
>> better.
>
> I somehow have the impression that subclassing is not a concern for Inven=
toryPrinter services and in fact may not even make sense. Which is probably=
 also why Web Console 4 does not walk the class hierarchy for finding Confi=
gurationPrinter methods.
>
> Regards
> Felix
>
>>>
>>> --
>>> Felix Meschberger | Principal Scientist | Adobe
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Carsten Ziegeler
>> cziegeler@apache.org
>
>
> --
> Felix Meschberger | Principal Scientist | Adobe
>
>
>
>
>
>
>


--=20
Carsten Ziegeler
cziegeler@apache.org