Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Date: Fri, 1 Feb 2013 16:24:13 +0000 (UTC)
From: "Pierre De Rop (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Message-ID: <JIRA.12629229.1359099158674.229982.1359735853149@arcas>
In-Reply-To: <JIRA.12629229.1359099158674@arcas>
References: <JIRA.12629229.1359099158674@arcas>
Subject: [jira] [Commented] (FELIX-3869) Fragment support for
 DependencyManager-Component
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/FELIX-3869?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1356=
8848#comment-13568848 ]=20

Pierre De Rop commented on FELIX-3869:
--------------------------------------

Hi Tuomas,

I committed in revision 1441505 the patch you submitted (many thanks to you=
 !), and slightly modified it in the following ways:

- since the PackageAdmin can be injected as a null object  (when dependency=
 is optional), I removed the check-if-not-null from the DependencyManagerRu=
ntime class file.
- in the bundleStarted method, I slightly modified the proposed patch in or=
der to always invoke the loadDescriptor(Bundle b, String url) method with t=
he
fragment-host bundle and not the fragments bundles, because we have to load=
 component classes using  the host bundle class loader, not from the fragme=
nts bundles.

I tested the patch using Felix and Equinox.=20
I'm closing now this issue. Feel free to reopen if you are not satisfied.

/Pierre

               =20
> Fragment support for DependencyManager-Component
> ------------------------------------------------
>
>                 Key: FELIX-3869
>                 URL: https://issues.apache.org/jira/browse/FELIX-3869
>             Project: Felix
>          Issue Type: Improvement
>          Components: Dependency Manager
>            Reporter: Tuomas Kiviaho
>            Assignee: Pierre De Rop
>         Attachments: Activator.patch, DependencyManagerRuntime.patch
>
>
> I've a use case where fragment support would be most welcome when declari=
ng dependencies.
> I propose that the 'DependencyManager-Component' header would cover fragm=
ents just like 'Service-Component' header does as per OSGI spec 112.4.1 Ser=
vice Component Header. This is quite easily implemented when BundleWiring i=
s supported although it would require shifting compilation to version 1.6. =
Current 1.5 version could use PackageAdmin.
> ***
> A Service-Component manifest header specified in a fragment is ignored by=
=20
> SCR. However, XML documents referenced by a bundle=E2=80=99s Service-Comp=
onent manifest header may be contained in attached fragments.=20
> SCR must process each XML document specified in this header. If an XML=20
> document specified by the header cannot be located in the bundle and its=
=20
> attached fragments, SCR must log an error message with the Log Service, i=
f=20
> present, and continue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira