felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3888) [DS] Expose the insides of ScrCommand as a service directly and enhance it
Date Sun, 03 Feb 2013 07:22:12 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569727#comment-13569727
] 

Felix Meschberger commented on FELIX-3888:
------------------------------------------

Basically, I agree that this might be helpful.

Some comments nevertheless:

* Adding support for regular expressions to select components in the shell commands sounds
like a good extension (I would even assume that .* is equivalent to providing no argument
to the command at all).
* But I think regular expression handling is a functionality of the ScrCommand and should
not be supported by the ScrService.
* Does it make sense to directly expose the Gogo Shell API with just a command argument and
out and err PrintStream as a service interface ?
* The ScrInfo service interface probably needs JavaDoc ;-) (incl. @since tag)
* The package export versions needs to be incremented
                
> [DS] Expose the insides of ScrCommand as a service directly and enhance it
> --------------------------------------------------------------------------
>
>                 Key: FELIX-3888
>                 URL: https://issues.apache.org/jira/browse/FELIX-3888
>             Project: Felix
>          Issue Type: Improvement
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.6.4
>            Reporter: David Jencks
>             Fix For: scr-1.6.4
>
>         Attachments: FELIX-3888-1.diff
>
>
> I have an environment where I'd like the basic capabilities of outputting the DS info
as text but not through the console.  We've been using the old Felix command but this has
always been odd and is getting too complicated.  Therefore I'd like to expose the ScrCommand
as a service directly.  I'm proposing to expose this only if an optional config admin property
ds.info.service is set to true.
> To further support this I'd like to make ScrCommand.getInfo(String id....) be able to
return info for all components.  I'm proposing to do this by letting id be a regexp to match,
so I can use ".*" and get all components.  (This is implemented in scrService.getComponents(String
componentIdentifier))
> For components from multiple bundles I'd like to sort the results by bundleId and componentId,
marking the bundle id changing.
> I'd like to modify the list command to sort the results by component id.
> The patch has a bit of java-5 updating that I missed the first time around.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message