Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6521EE2B3 for ; Thu, 31 Jan 2013 15:23:16 +0000 (UTC) Received: (qmail 18166 invoked by uid 500); 31 Jan 2013 15:23:15 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 17967 invoked by uid 500); 31 Jan 2013 15:23:15 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 17537 invoked by uid 99); 31 Jan 2013 15:23:15 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jan 2013 15:23:15 +0000 Date: Thu, 31 Jan 2013 15:23:15 +0000 (UTC) From: "Richard S. Hall (JIRA)" To: dev@felix.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FELIX-2921) [Framework] Improve property substitution handling in build process MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard S. Hall updated FELIX-2921: ----------------------------------- Fix Version/s: (was: framework-4.2.0) framework-4.4.0 > [Framework] Improve property substitution handling in build process > ------------------------------------------------------------------- > > Key: FELIX-2921 > URL: https://issues.apache.org/jira/browse/FELIX-2921 > Project: Felix > Issue Type: Improvement > Components: Framework > Affects Versions: framework-3.2.0 > Environment: apple > Reporter: Stephane Chomat > Priority: Minor > Fix For: framework-4.4.0 > > Attachments: BadPropertiesTest.java > > Original Estimate: 24h > Remaining Estimate: 24h > > The properties like FRAMEWORK_SYSTEMPACKAGES are bad substituted by the method Util.getDefaultProperty. > The properties dollar is missing and the value is '' returned by System.getProperty. > The bad default value for FRAMEWORK_SYSTEMPACKAGES is > org.osgi.framework; version=1.5.0, org.osgi.framework.launch; version=1.0.0, org.osgi.framework.hooks.service; version=1.0.0, org.osgi.service.packageadmin; version=1.2.0, org.osgi.service.startlevel; version=1.1.0, org.osgi.service.url; version=1.0.0, org.osgi.util.tracker; version=1.4.0 {jre-{java.specification.version}} > You can add this test : > public void testDefaultProperty() { > Logger logger = new Logger(); > > String jsv = System.getProperty("java.specification.version"); > String jre = Util.getDefaultProperty(logger, "jre-"+jsv); > > String actual = Util.getDefaultProperty(logger, Constants.FRAMEWORK_SYSTEMPACKAGES); > > assertEquals("org.osgi.framework; version=1.5.0, org.osgi.framework.launch; version=1.0.0, org.osgi.framework.hooks.service; version=1.0.0, org.osgi.service.packageadmin; version=1.2.0, org.osgi.service.startlevel; version=1.1.0, org.osgi.service.url; version=1.0.0, org.osgi.util.tracker; version=1.4.0 "+jre, actual); > } > If you add this line before test, the test works > System.setProperty("dollar","$"); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira