Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CABADBB1 for ; Mon, 19 Nov 2012 09:38:54 +0000 (UTC) Received: (qmail 2881 invoked by uid 500); 19 Nov 2012 09:38:53 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 2646 invoked by uid 500); 19 Nov 2012 09:38:53 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 2604 invoked by uid 99); 19 Nov 2012 09:38:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Nov 2012 09:38:51 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of fmeschbe@adobe.com designates 64.18.1.21 as permitted sender) Received: from [64.18.1.21] (HELO exprod6og108.obsmtp.com) (64.18.1.21) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 19 Nov 2012 09:38:41 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob108.postini.com ([64.18.5.12]) with SMTP ID DSNKUKn+DG6uBVmPaliNsweWuB0JF4WFCR5s@postini.com; Mon, 19 Nov 2012 01:38:21 PST Received: from inner-relay-4.eur.adobe.com (inner-relay-4.adobe.com [193.104.215.14]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id qAJ9ZT1v002111 for ; Mon, 19 Nov 2012 01:35:29 -0800 (PST) Received: from nacas03.corp.adobe.com (nacas03.corp.adobe.com [10.8.189.121]) by inner-relay-4.eur.adobe.com (8.12.10/8.12.9) with ESMTP id qAJ9cHXL018848 for ; Mon, 19 Nov 2012 01:38:18 -0800 (PST) Received: from eurcas01.eur.adobe.com (10.128.4.27) by nacas03.corp.adobe.com (10.8.189.121) with Microsoft SMTP Server (TLS) id 8.3.279.1; Mon, 19 Nov 2012 01:38:17 -0800 Received: from eurmbx01.eur.adobe.com ([10.128.4.32]) by eurcas01.eur.adobe.com ([10.128.4.27]) with mapi; Mon, 19 Nov 2012 09:38:15 +0000 From: Felix Meschberger To: Apache Felix Dev List Date: Mon, 19 Nov 2012 09:38:14 +0000 Subject: ServiceGraph Thread-Topic: ServiceGraph Thread-Index: Ac3GOZkGv78UJuuHQUqUzTD9ECgUig== Message-ID: <61695164-E935-4E95-A18F-EB08B5F00B33@adobe.com> Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: de-DE, en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org Hi I tried to tackle FELIX-3764 [1] just to realize that this plugin IMHO is n= ot properly integrated with the web console: * registers a /servicegraph/json servlet * registers /servicegraphe resources The problem with this is, that it doesn't account for non-root servlet cont= exts, is not integrated with the URL space and does not leverage the Web Co= nsole access control mechanisms. I suggest to change this plugin as follows: * Handle the .../json request as part of the WebConsolePlugin.service met= hod * Implement a URL getResource [2] method in the WebConsolePlugin class This allows for full integration, leveraging access control and URL space i= ntegration plus also allows for using the appRoot and pluginRoot Web Consol= e properties [3]. Does this make sense ? Regards Felix [1] https://issues.apache.org/jira/browse/FELIX-3764 [2] http://felix.apache.org/site/providing-resources.html [3] http://felix.apache.org/site/providing-web-console-plugins.html=