felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Georg Henzler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3711) Make more REST Urls available in UI (component id/name and service pid is often not clickable)
Date Mon, 15 Oct 2012 11:44:02 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476089#comment-13476089
] 

Georg Henzler commented on FELIX-3711:
--------------------------------------

=> RE "presentation task better done in the respective JavaScript"

Not "polluting" the JSON with Html is a good point - so I agree a frontend js solution could
be the better approach. Let's have a look at the JSON how it's currently delivered:
....
{  "key": "Bundle-SymbolicName", "value": "com.day.cq.wcm.cq-wcm-foundation"  }
....
{  "key": "Service ID <a href='/system/console/services/797'>797</a>",
    "value": [
        "Types: javax.servlet.Servlet, javax.servlet.ServletConfig, java.io.Serializable",
        "Service PID: com.day.cq.wcm.foundation.ParagraphServlet",
        "Component Name: com.day.cq.wcm.foundation.ParagraphServlet",
        "Component ID: 563",
        "Vendor: Day Management AG"
] }

We have some html in the JSON already (Service ID-Link)... to get rid of it (and to support
the new feature of this issue) we could refactor it as follows:

{  "key": "Bundle-SymbolicName", "label": "Symbolic Name", "value": "com.day.cq.wcm.cq-wcm-foundation",
"link": "http://.... can be optional"  }
....
{  "key": "service.id", "label": "Service ID",  "link": "/system/console/services/797"  
    "value": [
...
        { "key":  "component.name",  "Label": "Component Name" com.day.cq.wcm.foundation.ParagraphServlet",
"link": "http://.... can be optional"  }
...
]}

But obviously this would mean a bit of refactoring on both JS and Java sides.


=> RE: "BundleInfo approach superior"
IMHO, this not the case - the BundleInfo mechanism would get a lot more complicated to be
able to hook into the basic display of the bundle... I believe the links should be a "first
level citizen" in the UI and not be provided by some sort of plugin mechanism.
                
> Make more REST Urls available in UI (component id/name and service pid is often not clickable)
> ----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3711
>                 URL: https://issues.apache.org/jira/browse/FELIX-3711
>             Project: Felix
>          Issue Type: New Feature
>          Components: Web Console
>    Affects Versions: webconsole-4.0.0
>            Reporter: Georg Henzler
>         Attachments: org.apache.felix.webconsole.patch-for-FELIX-3711-v2.patch
>
>
> Many REST urls already work if created manually, but are not yet available as links in
the UI:
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole
> http://localhost:8080/system/console/bundles/org.apache.felix.webconsole:4.0.1.SNAPSHOT
> http://localhost:8080/system/console/configMgr/org.apache.felix.webconsole.plugins.event.internal.PluginServlet
> http://localhost:8080/system/console/components/com.test.scr.ClassB
> It would be easy to put the appropriate link behind the property values in bundles/configuration/services
detail views. 
> I use the REST Urls a lot as they are really valuable in email/instant messenger/JIRA/WIKI
to bring people with one click to the desired location, therefore it would be nice to not
have to construct them manually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message