Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38302CF51 for ; Mon, 21 May 2012 19:11:43 +0000 (UTC) Received: (qmail 95551 invoked by uid 500); 21 May 2012 19:11:42 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 95433 invoked by uid 500); 21 May 2012 19:11:42 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 95239 invoked by uid 99); 21 May 2012 19:11:42 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2012 19:11:42 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 3F6DF141822 for ; Mon, 21 May 2012 19:11:42 +0000 (UTC) Date: Mon, 21 May 2012 19:11:40 +0000 (UTC) From: "Thomas Watson (JIRA)" To: dev@felix.apache.org Message-ID: <1883954688.4349.1337627502261.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1031318767.4098.1337624140848.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (FELIX-3517) Use of internal Logger seems not worth it MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280378#comment-13280378 ] Thomas Watson commented on FELIX-3517: -------------------------------------- I'm fine with keeping the abstraction, I was just surprised when I found it only being used in one place and I was contemplating using it in other places in case we need to trace other things. For example dynamic imports etc. > Use of internal Logger seems not worth it > ----------------------------------------- > > Key: FELIX-3517 > URL: https://issues.apache.org/jira/browse/FELIX-3517 > Project: Felix > Issue Type: Bug > Components: Resolver > Environment: All > Reporter: Thomas Watson > > This may be a point in time issue, but the use of the internal logger (org.apache.felix.resolver.Logger) seems a bit overboard since it is only used in one place in the method org.apache.felix.resolver.ResolverImpl.checkPackageSpaceConsistency > Should we be adding more usages of this logger for debugging or is it really intended to be used to debug class space consistency issues? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira