Return-Path: X-Original-To: apmail-felix-dev-archive@www.apache.org Delivered-To: apmail-felix-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 967F09E4F for ; Fri, 6 Apr 2012 13:37:47 +0000 (UTC) Received: (qmail 29480 invoked by uid 500); 6 Apr 2012 13:37:47 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 29426 invoked by uid 500); 6 Apr 2012 13:37:47 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 29412 invoked by uid 99); 6 Apr 2012 13:37:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2012 13:37:47 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Apr 2012 13:37:44 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9046635CD0F for ; Fri, 6 Apr 2012 13:37:23 +0000 (UTC) Date: Fri, 6 Apr 2012 13:37:23 +0000 (UTC) From: "Richard S. Hall (Commented) (JIRA)" To: dev@felix.apache.org Message-ID: <809020788.23357.1333719443609.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1806781303.22285.1333693250937.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (FELIX-3447) Optimize read only collections by using a specific class and not a wrapper which is slower MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FELIX-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248339#comment-13248339 ] Richard S. Hall commented on FELIX-3447: ---------------------------------------- Just curious as to whether you have some empirical evidence that this is an issue or if you are just guessing? It would be nice to see a comparison. > Optimize read only collections by using a specific class and not a wrapper which is slower > ------------------------------------------------------------------------------------------ > > Key: FELIX-3447 > URL: https://issues.apache.org/jira/browse/FELIX-3447 > Project: Felix > Issue Type: Improvement > Components: Framework > Affects Versions: framework-4.0.2 > Reporter: Guillaume Nodet > Fix For: framework-4.2.0 > > Attachments: FELIX-3447.patch > > > The unmodifiable collection wrappers are .. wrappers and as such add a slight overhead. > In the case of felix, the resolution process does use a lot of those maps for bundle capabilities and requirements and the overhead tends to become non negligible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira