felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3202) Add generic type information to SimpleFilter
Date Mon, 07 Nov 2011 06:29:51 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145248#comment-13145248
] 

Richard S. Hall commented on FELIX-3202:
----------------------------------------

This replaces one class with 13 to add generics? Is that correct? If so, it seems like overkill
to me. I'd certainly be interested in any performance improvements you can find, but i'd prefer
it to be piecemeal against the current "simple" implementation.

Also, this does the matching in the filter implementation, which is not what we want, since
matching needs to be run against our indices in CapabilitySet. That's why CapabilitySet does
the matching currently. The OSGi spec historically reversed the direction here by having the
filter do the matching, but that is not really what you want because it forces you to pass
one capability at a time to the filter.
                
> Add generic type information to SimpleFilter
> --------------------------------------------
>
>                 Key: FELIX-3202
>                 URL: https://issues.apache.org/jira/browse/FELIX-3202
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>            Reporter: Lucas Galfaso
>            Priority: Minor
>         Attachments: felix_java5_filter.diff
>
>
> SimpleFilter does not have Java 5 generic type information and it is very hard to add
this to the current implementation.
> Devise a way to add generate type information to SimpleFilter while keeping in mind that
this is a critical component and any performance degradation would slow down the entire framework

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message