felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3202) Add generic type information to SimpleFilter
Date Fri, 11 Nov 2011 03:02:51 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148236#comment-13148236
] 

Richard S. Hall commented on FELIX-3202:
----------------------------------------

Keep in mind that the indexed case is the normal case for just about all use cases. It is
how the resolver works and how the service registry works. Calling Filter.match() is not common,
so its performance is less critical. Still, if we can improve it, then good.

Internally, I tried to use the same code to do the match in either case to avoid duplication
of code and the bugs that result, so this is likely why the matching in the single matching
case in the current implementation is slower since it is more generic (and thus more complicated)
than it needs to be for single matching.

Still, the thing to remember is that single matching is much less important than the indexed
case.
                
> Add generic type information to SimpleFilter
> --------------------------------------------
>
>                 Key: FELIX-3202
>                 URL: https://issues.apache.org/jira/browse/FELIX-3202
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>            Reporter: Lucas Galfaso
>            Priority: Minor
>         Attachments: felix_java5_filter.diff
>
>
> SimpleFilter does not have Java 5 generic type information and it is very hard to add
this to the current implementation.
> Devise a way to add generate type information to SimpleFilter while keeping in mind that
this is a critical component and any performance degradation would slow down the entire framework

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message