felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3198) Support generic configuration properties
Date Fri, 04 Nov 2011 10:27:00 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143892#comment-13143892

Felix Meschberger commented on FELIX-3198:

In what respect standard or non-standard ? The OSGi Configuration Admin just provides a Dictionary
of properties and the administrator/tool preparing the configuration can put in there what
they like. As such this is IMHO along the lines of spec.

Now, what is special here, of course, is that not all properties actually supported by the
service are declared in the metatype descriptor. This of course prevents these properties
from directly and easily be edited in a metatype based configuration GUI, such as the web
console. Unless the tool allows for raw configuration property editing. While this might be
bending the concepts a bit, I don't think it really violates any spec.

As for the servlet context path: The path configured here is the path to which the servlet
cookie is bound. By default this is the servlet context path but it can be narrowed down.
This, of course, is a Jetty feature which technically probably violates the Servlet API spec.
Same as the cookie name and request parameter name configurations, where spec reads rather
strict: The names have to be JSESSIONID for the cookie and jsessionid for the request parameter.

The session does not talk about the session cookie's domain directly, though. And we had customers
actually asking for the session cookie's domain to be something different than the default.

As a consequence:
-- I think it is ok to support configuration parameters not exposed through Metatype
-- In retrospect (and there is still time to fix this), I am not sure whether it is good to
expose the session cookie name, parameter name and cooke path properties
-- I think having the cookie domain and lifetime configurable is ok, though.

> Support generic configuration properties
> ----------------------------------------
>                 Key: FELIX-3198
>                 URL: https://issues.apache.org/jira/browse/FELIX-3198
>             Project: Felix
>          Issue Type: Improvement
>          Components: HTTP Service
>    Affects Versions: http-2.2.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: http-2.2.2
> Currently the Jetty configuration only allows for a hard-coded limited sets of properties
provided in either the Configuration Admin configuration or as framework properties.
> Adding support for generic properties allows administrators to configure the Servlet
Container more specifically. Examples of such properties would be Jetty specific session configuration.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message