felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FELIX-3175) RankingComparator results in wrong results
Date Thu, 20 Oct 2011 12:17:11 GMT

     [ https://issues.apache.org/jira/browse/FELIX-3175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Felix Meschberger resolved FELIX-3175.
--------------------------------------

    Resolution: Fixed

Fixed in Rev. 1186756
                
> RankingComparator results in wrong results
> ------------------------------------------
>
>                 Key: FELIX-3175
>                 URL: https://issues.apache.org/jira/browse/FELIX-3175
>             Project: Felix
>          Issue Type: Bug
>          Components: Configuration Admin
>    Affects Versions: configadmin-1.2.10
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: configadmin-1.2.12
>
>
> The RankingComparator class is used for two cases: ordering ConfigurationPlugin services
as per the service.cmRanking property and ordering services as per the service.ranking property.
These orderings are slightly different for which the class does not provide properly:
> * service.cmRanking sorts ascending and does not define an order amongst services with
the same cmRanking value
> * service.ranking sorts in descending property value order and defines to fall back to
service.id ordering (ascending) in case of equal service.ranking values.
> The RankingComparator should be fixed (and simplified) to cope with these two mechanisms.
> This should also be tested using unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message