felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FELIX-3000) Move sending service registered event out of bundle lock
Date Thu, 16 Jun 2011 17:05:47 GMT

    [ https://issues.apache.org/jira/browse/FELIX-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050565#comment-13050565

Richard S. Hall commented on FELIX-3000:

Regarding Callbacks, original the service registry used a full-blown listener pattern, but
this seemed overkill since the framework was the only listener, thus I replaced that with
a single "callbacks" object. What we are essentially proposing is to remove any notion of
events from the service registry and handle them completely externally. I think the tricky
one is unregister.

Regarding 4.0, I don't think it will be done until end of July at the earliest. Branching
is not a big deal, really, we just create a branch from the 3.2.2 tag, apply the fix, do a
release, remove the branch. So, if we have to go that route, then no big deal. It only becomes
more difficult if there are a lot of other issues to port over from trunk to the branch...but
we could only include this one issue.

> Move sending service registered event out of bundle lock
> --------------------------------------------------------
>                 Key: FELIX-3000
>                 URL: https://issues.apache.org/jira/browse/FELIX-3000
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>    Affects Versions: framework-3.0.7, framework-3.2.2
>            Reporter: Felix Meschberger
>             Fix For: framework-4.0.0
>         Attachments: FELIX-3000-stacktrace.txt, FELIX-3000.patch
> We have a strange situation on a Framework 3.0.7 based system here which is not reproducible
on all platforms.
> We can track down a system freeze/deadlock to three threads all contending for bundle
locks and the global lock. See attached FELIX-3000-stacktrace.txt for the stack trace.
> Looking at the Framework source, particularly acquireBundleLock and acquireGlobalLock
I cannot see where this "deadlock" can occur.
> The only hint I have is a note in the Felix.registerService:
> > // TODO: CONCURRENCY - Reconsider firing event here, outside of the
> > // bundle lock.
> I wonder whether this situation can be fixed with moving the service registration event
> Looking at the code it seems to have not been changed. Thus I report this against 3.0.7
where we saw this and 3.2.2 being the latest release.

This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message