Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
From: Marcel Offermans <marcel.offermans@luminis.nl>
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: multipart/alternative; boundary=Apple-Mail-68--480772327
Subject: Re: [VOTE] Release Felix Deployment Admin version 0.9.0,
 AutoConf 0.1.0, Dependency Manager 3.0.0
Date: Sun, 1 May 2011 11:59:02 +0200
In-Reply-To: <C9E2CFC3.19857%clement.escoffier@gmail.com>
To: <dev@felix.apache.org>
References: <C9E2CFC3.19857%clement.escoffier@gmail.com>
Message-Id: <0167AFF4-693C-4D49-A5E0-98516C869DCE@luminis.nl>

--Apple-Mail-68--480772327
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Hello Clement,

Thanks for your review. Especially the missing headers are serious =
enough to cancel this vote and redo the release. Some comments below:

> Dependency Manager: +1 with comments
> * No changelog

Mostly I did not do this because either "everything changed" (for =
dependency manager, it's an incompatible update) or its a "first =
release".

> * Wrong Dependencies format:
> 'This software was developed at the Apache Software Foundation
> (http://www.apache.org) and may have dependencies on other
> Apache software licensed under Apache License 2.0.' missing

That's a mistake I will fix.

> Dependency Manager Annotation: -1
> * No changelog
> * Missing Apace header in:
> src/main/java/org/apache/felix/dm/annotation/plugin/bnd/Patterns.java
> =
src/main/java/org/apache/felix/dm/annotation/plugin/bnd/EntryWriter.java
> src/main/java/org/apache/felix/dm/annotation/plugin/bnd/EntryType.java
> =
src/main/java/org/apache/felix/dm/annotation/plugin/bnd/EntryParam.java

Showstopper. Will be fixed and I'll do a new release.

> * the DEPENDENCIES declares you're using json... But I didn't find any
> reference on json

There is one, in EntryWriter.java, so I'll leave that one in.

> Dependency Manager Compat: +1 with comments
> * No changelog
>=20
> Dependency Manager Runtime: +1
>=20
> Dependency Manager Shell: ?
> * No changelog
> * Wrong Dependencies format:
> 'This software was developed at the Apache Software Foundation
> (http://www.apache.org) and may have dependencies on other
> Apache software licensed under Apache License 2.0.' missing
> * Is using EPL Ok ?

See:
http://www.apache.org/legal/3party.html

It's mentioned in "category B". We're just implementing an API here, =
importing the package at runtime if it's available, so as far as I =
understand that is allowed.

> AutoConf: +1 with comments
> * No changelog
> * Wrong Dependencies format:
> 'This software was developed at the Apache Software Foundation
> (http://www.apache.org) and may have dependencies on other
> Apache software licensed under Apache License 2.0.' missing
> * The KXML License is superfluous in the NOTICE file (BSD)

Ok.

> Deployment Admin: +1 with comments:
> * No changelog
> * Wrong Dependencies format:
> 'This software was developed at the Apache Software Foundation
> (http://www.apache.org) and may have dependencies on other
> Apache software licensed under Apache License 2.0.' missing

Ok.

Greetings, Marcel


--Apple-Mail-68--480772327--