felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Clement Escoffier (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-2834) @Validate method is called when the @Requires components are not validated yet
Date Tue, 15 Feb 2011 18:25:58 GMT

    [ https://issues.apache.org/jira/browse/FELIX-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994917#comment-12994917
] 

Clement Escoffier commented on FELIX-2834:
------------------------------------------

How does c2 expose itself ? Is it a service ?

Because with:
@Component
class Component1
{
  @Requires
  Component2 c2;

  @Validate
  public void init() {
    // this may cause an NullPointerException, as c2.usefullData is created in the @Validate
method
    if (c2.usefullData.length()>0) {
        System.out.println("Youhou " + c2.usefullData);
    }
  }
}

@Component
@Provides(specifications=Component2.class)
public class Component2
{
  String usefullData;
  @Validate
  public void init() { usefullData="ready"; }
}

and this metadata:
<instance component="ipojo.test.org.apache.felix.ipojo.felix2834.Component1"/>
<instance component="ipojo.test.org.apache.felix.ipojo.felix2834.Component2"/>

I got the expected result:
Youhou ready

I'm using iPOJO 1.8.0.


> @Validate method is called when the @Requires components are not validated yet
> ------------------------------------------------------------------------------
>
>                 Key: FELIX-2834
>                 URL: https://issues.apache.org/jira/browse/FELIX-2834
>             Project: Felix
>          Issue Type: Bug
>          Components: iPOJO
>    Affects Versions: iPOJO-1.6.0
>            Reporter: Vincent Vandemeulebrouck
>            Assignee: Clement Escoffier
>              Labels: callback, metadata, require, validation
>
> Declare two components one that requires the other.
> Have an @Validate method.
> Depending on the declaration order in the metadata.xml, the component that requires the
other may have acces to a component which has not been validated.
> Example:
> @Component
> class Component1
> {
>   @Requires
>   Component2 c2;
>   @Validate
>   public void init() {
>     // this may cause an NullPointerException, as c2.usefullData is created in the @Validate
method
>     if (c2.usefullData.length()>0) {
>         // Do something
>     }
>   }
> }
> @Component
> class Component2
> {
>   String usefullData;
>   @Validate
>   public void init() { usefullData="ready"; }
> }
> If you declare this metadata.xml, the @Validate will fail:
> <ipojo>
>    <instance component="Component1" />
>    <instance component="Component2" />
> </ipojo>
> Changing the order of components in xml solves the problem, although I think the validation
should be called only when the required components are validated.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message