felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Klimetschek (JIRA)" <j...@apache.org>
Subject [jira] Created: (FELIX-2835) SCR plugin: Parsing of "options" for property tag broken for javadoc annotations
Date Thu, 10 Feb 2011 13:53:57 GMT
SCR plugin: Parsing of "options" for property tag broken for javadoc annotations
--------------------------------------------------------------------------------

                 Key: FELIX-2835
                 URL: https://issues.apache.org/jira/browse/FELIX-2835
             Project: Felix
          Issue Type: Bug
          Components: Maven SCR Plugin
    Affects Versions:  scr-1.6.0
            Reporter: Alexander Klimetschek


A property with options should use the key=value parameters after the "options" parameter
as name=label for the metatype options:

    @scr.property type="String" value="one" options one="One" two="Two" three="Three"

However, it produces this single option:

            <Option value="one=One" label="three=Three"/>

The problem is that this loop is inherently broken due to both a "j++" in the for loop and
a "j += 2" at the end, and a parameters[j+2]:

            for (int j=0; j < parameters.length; j++) {
                if (Constants.PROPERTY_OPTIONS.equals(parameters[j])) {
                    options = new LinkedHashMap<String, String>();
                } else if (options != null) {
                    String optionLabel = parameters[j];
                    String optionValue = (j < parameters.length-2) ? parameters[j+2] :
null;
                    if (optionValue != null) {
                        options.put(optionLabel, optionValue);
                    }
                    j += 2;
                }
            }

Without having debugged it, I guess it should be parameters[j+1] and j+=1, as you only skip
one parameter for reading the label, not two (given that one="One" is represented as two parameters
"one" and "One").

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message