felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (FELIX-2691) Apache Felix HTTP service HttpServiceImpl.isNameValid does not match OSGi R4.2 spec?
Date Sat, 08 Jan 2011 00:27:45 GMT

     [ https://issues.apache.org/jira/browse/FELIX-2691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Felix Meschberger resolved FELIX-2691.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: http-2.0.6

Thanks for providing the patch.

Fixed in Rev. 1056570

> Apache Felix HTTP service HttpServiceImpl.isNameValid does not match OSGi R4.2 spec?
> ------------------------------------------------------------------------------------
>
>                 Key: FELIX-2691
>                 URL: https://issues.apache.org/jira/browse/FELIX-2691
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-2.0.4
>         Environment: Not relevant
>            Reporter: Misha Koshelev
>            Assignee: Felix Meschberger
>             Fix For: http-2.0.6
>
>         Attachments: FELIX-2691-HttpServiceImpl-isNameValid-comply-OSGI-R42.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Filing bug per:
> http://www.mail-archive.com/dev@felix.apache.org/msg19853.html
> The R4.2 enterprise spec from
> http://www.osgi.org/Download/File?url=/download/r4v42/r4.enterprise.pdf
> on page 48 clearly states:
> The name parameter must also not end with slash ('/') with the
> exception that a name of the form "/" is used to denote the root of
> the bundle.
> The relevant code, in trunk, is, from
> http://svn.apache.org/repos/asf/felix/trunk/http/base/src/main/java/org/apache/felix/http/base/internal/service/HttpServiceImpl.java
>  public void registerResources(String alias, String name, HttpContext context)
>         throws NamespaceException
>     {
>         if (!isNameValid(name)) {
>             throw new IllegalArgumentException( "Malformed resource
> name [" + name + "]");
>         }
> ...
> and
> private boolean isNameValid(String name)
>     {
>         if (name == null) {
>             return false;
>         }
>         if (name.endsWith( "/" )) {
>             return false;
>         }
>         return true;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message