Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 37432 invoked from network); 17 Nov 2010 20:12:07 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 17 Nov 2010 20:12:07 -0000 Received: (qmail 83855 invoked by uid 500); 17 Nov 2010 20:12:38 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 83762 invoked by uid 500); 17 Nov 2010 20:12:37 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 83754 invoked by uid 99); 17 Nov 2010 20:12:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Nov 2010 20:12:37 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Nov 2010 20:12:35 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAHKCDej006477 for ; Wed, 17 Nov 2010 20:12:14 GMT Message-ID: <22113832.157581290024733403.JavaMail.jira@thor> Date: Wed, 17 Nov 2010 15:12:13 -0500 (EST) From: "Guillaume Nodet (JIRA)" To: dev@felix.apache.org Subject: [jira] Commented: (FELIX-2698) File Install Circular Configuration Update Loop In-Reply-To: <24459406.128841289946437199.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-2698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933124#action_12933124 ] Guillaume Nodet commented on FELIX-2698: ---------------------------------------- Do you plan to provide some patches for the 3 issues you raised ? That would be more than welcome ! > File Install Circular Configuration Update Loop > ----------------------------------------------- > > Key: FELIX-2698 > URL: https://issues.apache.org/jira/browse/FELIX-2698 > Project: Felix > Issue Type: Bug > Components: File Install > Affects Versions: fileinstall-3.1.0 > Reporter: David Hay > > Using FileInstall 3.1.0, when I update a .cfg file, the system is sent into an infinite loop of updating the Configuration Admin Service and rewriting the cfg file. The cycle goes something like this: > 1. Updated .cfg file is noticed by File Install DirectoryWatcher > 2. The Configuration object is obtained and updated (in ConfigInstaller.setConfig(File)) > 3. The Configuration Admin Service fires a ConfigurationEvent > 4. ConfigInstaller receives the ConfigurationEvent and writes out the new properties to the .cfg > 5. Go to step 1 > It seems like the ConfigInstaller object should figure out if the ConfigurationEvent is in response to an update to the .cfg file it just loaded. > One way to do this might be to put a "special" value in the Configuration that the ConfigurationListener method could look for. > Another way would be to compare the configuration in the .cfg file to the properties that would normally be written. If they're the same, don't write the file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.