felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Richard S. Hall (JIRA)" <j...@apache.org>
Subject [jira] Created: (FELIX-2712) [SCR] Add Gogo command support
Date Tue, 30 Nov 2010 16:46:11 GMT
[SCR] Add Gogo command support
------------------------------

                 Key: FELIX-2712
                 URL: https://issues.apache.org/jira/browse/FELIX-2712
             Project: Felix
          Issue Type: New Feature
          Components: Declarative Services (SCR)
    Affects Versions:  scr-1.6.0
            Reporter: Richard S. Hall
             Fix For: scr-1.6.2


Currently, SCR only provides an "scr" command for the old shell. It should also include a
Gogo command. A very simple approach would be to factor out the command implementation from
the Command interface, to eliminate the dependency on the Shell package. This object would
simply have a single method like public void scr(String[] args) that would do the current
processing. For Gogo you'd just register this object directly as the command with some service
properites, for Shell you'd wrap it in a Command.

A better approach would be to look at the OBR command for Gogo. In it, all OBR subcommands
(e.g., obr list) just become methods on the service object and accept the needed parameters.
The "obr" command becomes the command scope (in the service properties), so you can do "obr:list"
at the Gogo prompt or just "list" if there is no ambiguity. You could still wrap this object
in a Command to be compatible with Shell.

I'd recommend the second approach, since it allows you to leverage the Gogo annotations to
provide decent help for the command.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message