felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Felix Meschberger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to date bnd
Date Tue, 26 Oct 2010 08:42:30 GMT

    [ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924894#action_12924894
] 

Felix Meschberger commented on FELIX-2176:
------------------------------------------

I tend to agree with Peter that adding a default Export-Package is not a very good idea.

It is probably only acceptable idea for bundles exporting anything. But for bundles which
contain some exports and some private packages, the bundle version will increase on each release
for modified private packages and then increasing the export version automatically just sounds
a bad idea.

So I would argue to not do it (and not even in the interest of being pragmatism), because
it IMHO will generate more pain than relieve.

For example: In our commercial application we currently don't use much Export-Package versioning
(yes, this is another issue we have to solve). Having automatic export versions will completely
prevent us from properly updating bundles.

> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
>                 Key: FELIX-2176
>                 URL: https://issues.apache.org/jira/browse/FELIX-2176
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.1
>            Reporter: David Jencks
>             Fix For: maven-bundle-plugin-2.1.0
>
>         Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private
repo.  The bundle plugin can copy bnd into itself so users don't have to have peter's secret
stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd.  I can't see any reason to keep the copied
Builder source -- plugin passes tests and appears to work without it -- so I removed it. 
You'll need to run
> svn rm    src/main/java/aQute/lib/osgi/Builder.java
> Also the code in   src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java
_really_ doesn't compile any more and I suspect the functionality has moved into bnd.  However
I can't actually tell what its trying to do; I commented it out.  If this functionality is
actually in bnd then removing the class would be a good idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message