felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-2436) Reduce the number files created by the fileinstall Scanner.
Date Tue, 26 Oct 2010 07:57:21 GMT

    [ https://issues.apache.org/jira/browse/FELIX-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924882#action_12924882
] 

Guillaume Nodet commented on FELIX-2436:
----------------------------------------

I think checking the length of the file is important, especially when you copy a big file
and that the write isn't atomic enough.   For example when copying a big war, if the copy
is still running while the scan is done and that the copy takes more time than the scan interval,
there are good chances the check will return true, while the file isn't fully copied.
So i'm not 100% confident with applying this patch...

> Reduce the number files created by the fileinstall Scanner.
> -----------------------------------------------------------
>
>                 Key: FELIX-2436
>                 URL: https://issues.apache.org/jira/browse/FELIX-2436
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-2.0.8
>            Reporter: Peter Lawrey
>         Attachments: reduce_object_construction.patch
>
>
> The fileinstaller is called regularly and there can be two or more instances in a server.
> However its object allocation doesn't considered that 99.999+% of the time none of the
files change. 
> (polling one per second and changing files once per day is means the file installer will
see a change 0.001% of the time)
> In our application, polling every second results in the Scanner creating more objects
than the application itself. We can turn down the polling rate but even at once every 10s
it creates more objects than any other component!
> For this reason I have changed the Scanner to first check whether any files have changed
attempting to compute what has changed.
> See atached for a patch of the changes.  This reduces the number of obejcts created by
atleast a factor of 3.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message