Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 60989 invoked from network); 22 Jun 2010 15:58:22 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Jun 2010 15:58:22 -0000 Received: (qmail 15810 invoked by uid 500); 22 Jun 2010 15:58:22 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 15753 invoked by uid 500); 22 Jun 2010 15:58:21 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 15745 invoked by uid 99); 22 Jun 2010 15:58:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jun 2010 15:58:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jun 2010 15:58:19 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o5MFvv3w018266 for ; Tue, 22 Jun 2010 15:57:58 GMT Message-ID: <20468145.15081277222277891.JavaMail.jira@thor> Date: Tue, 22 Jun 2010 11:57:57 -0400 (EDT) From: "Peter Lawrey (JIRA)" To: dev@felix.apache.org Subject: [jira] Updated: (FELIX-2436) Reduce the number files created by the fileinstall Scanner. In-Reply-To: <9912623.15001277221974262.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/FELIX-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Lawrey updated FELIX-2436: -------------------------------- Attachment: reduce_object_construction.patch patch of changes to reduce object allocation. > Reduce the number files created by the fileinstall Scanner. > ----------------------------------------------------------- > > Key: FELIX-2436 > URL: https://issues.apache.org/jira/browse/FELIX-2436 > Project: Felix > Issue Type: Improvement > Components: File Install > Affects Versions: fileinstall-2.0.8 > Reporter: Peter Lawrey > Attachments: reduce_object_construction.patch > > > The fileinstaller is called regularly and there can be two or more instances in a server. > However its object allocation doesn't considered that 99.999+% of the time none of the files change. > (polling one per second and changing files once per day is means the file installer will see a change 0.001% of the time) > In our application, polling every second results in the Scanner creating more objects than the application itself. We can turn down the polling rate but even at once every 10s it creates more objects than any other component! > For this reason I have changed the Scanner to first check whether any files have changed attempting to compute what has changed. > See atached for a patch of the changes. This reduces the number of obejcts created by atleast a factor of 3. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.