Mailing-List: contact dev-help@felix.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@felix.apache.org
Message-ID: <22805846.1511273687008980.JavaMail.jira@thor>
Date: Wed, 12 May 2010 13:56:48 -0400 (EDT)
From: "Jamie goodyear (JIRA)" <jira@apache.org>
To: dev@felix.apache.org
Subject: [jira] Commented: (FELIX-2280) To much code duplication in
 DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
In-Reply-To: <27264362.53661271181175273.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/FELIX-2280?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1286=
6663#action_12866663 ]=20

Jamie goodyear commented on FELIX-2280:
---------------------------------------

No worries. I'm still working my way through test cases and reviewing the c=
ode - so far happy :)

I've noticed that in the OracleJDBCLock updateLock override code that your =
eventually re-executing "SELECT * FROM tableName FOR UPDATE" as the keep al=
ive mechanism. Do we need to keep instructing Oracle that this is for Updat=
e here once we've already captured the table lock? A "SELECT * FROM tableNa=
me" should suffice.


> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBC=
Lock
> -------------------------------------------------------------------------=
----
>
>                 Key: FELIX-2280
>                 URL: https://issues.apache.org/jira/browse/FELIX-2280
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>    Affects Versions: karaf-1.4.0
>         Environment: All
>            Reporter: Christian M=C3=BCller
>            Assignee: Jamie goodyear
>         Attachments: FELIX-2280.patch, FELIX-2280.patch, FELIX-2280.patch=
, FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock, org.apache.felix.karaf.main.=
MySQLJDBCLock and org.apache.felix.karaf.main.OracleJDBCLock has to much co=
de duplications. I propose a solution like in ActiveMQ [package org.apache.=
activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/act=
ivemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provid=
e a patch for it.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.