felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jamie goodyear (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FELIX-2280) To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
Date Thu, 06 May 2010 18:36:48 GMT

    [ https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864879#action_12864879
] 

Jamie goodyear commented on FELIX-2280:
---------------------------------------

No problem Christian, this is why we review patches ;)

I'm still going over the patch, I want to try it out with a few different DBs in various situations.


I also want to take some time to see why & where each of the messages are being generated
in unit tests. They're probably ok, just want to validate it :) 

Sample output:
{code}
Running org.apache.felix.karaf.main.DefaultJDBCLockTest
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock schemaExists
SEVERE: Error testing for db table: java.lang.NullPointerException
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock createSchema
SEVERE: Could not create schema: java.lang.IllegalStateException: missing behavior definition
for the preceeding method call getMetaData()
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock updateLock
WARNING: Failed to update database lock: java.sql.SQLException
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock updateLock
WARNING: Failed to update database lock: java.sql.SQLException
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock isAlive
SEVERE: Lost lock!
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock isAlive
SEVERE: Lost lock!
6-May-2010 11:05:59 AM org.apache.felix.karaf.main.DefaultJDBCLock updateLock
WARNING: Failed to update database lock: java.sql.SQLException
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.176 sec
{code}

> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
>                 Key: FELIX-2280
>                 URL: https://issues.apache.org/jira/browse/FELIX-2280
>             Project: Felix
>          Issue Type: Improvement
>          Components: Karaf
>    Affects Versions: karaf-1.4.0
>         Environment: All
>            Reporter: Christian Müller
>         Attachments: FELIX-2280.patch, FELIX-2280.patch, FELIX-2280.patch, FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock, org.apache.felix.karaf.main.MySQLJDBCLock
and org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I propose a
solution like in ActiveMQ [package org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a patch for
it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message