Return-Path: Delivered-To: apmail-felix-dev-archive@www.apache.org Received: (qmail 74548 invoked from network); 13 Apr 2010 17:53:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 13 Apr 2010 17:53:19 -0000 Received: (qmail 90099 invoked by uid 500); 13 Apr 2010 17:53:19 -0000 Delivered-To: apmail-felix-dev-archive@felix.apache.org Received: (qmail 90063 invoked by uid 500); 13 Apr 2010 17:53:19 -0000 Mailing-List: contact dev-help@felix.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@felix.apache.org Delivered-To: mailing list dev@felix.apache.org Received: (qmail 90055 invoked by uid 99); 13 Apr 2010 17:53:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Apr 2010 17:53:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Apr 2010 17:53:17 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o3DHqtk1025269 for ; Tue, 13 Apr 2010 13:52:55 -0400 (EDT) Message-ID: <27264362.53661271181175273.JavaMail.jira@thor> Date: Tue, 13 Apr 2010 13:52:55 -0400 (EDT) From: =?utf-8?Q?Christian_M=C3=BCller_=28JIRA=29?= To: dev@felix.apache.org Subject: [jira] Created: (FELIX-2280) To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLo= ck ---------------------------------------------------------------------------= -- Key: FELIX-2280 URL: https://issues.apache.org/jira/browse/FELIX-2280 Project: Felix Issue Type: Improvement Components: Karaf Affects Versions: karaf-1.4.0 Environment: All Reporter: Christian M=C3=BCller org.apache.felix.karaf.main.DefaultJDBCLock, org.apache.felix.karaf.main.My= SQLJDBCLock and org.apache.felix.karaf.main.OracleJDBCLock has to much code= duplications. I propose a solution like in ActiveMQ [package org.apache.ac= tivemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activ= emq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/]. And we should implement some unit tests for it. If it's fine for you, I will try to improve this part of karaf and provide = a patch for it. --=20 This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: htt= ps://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira