felix-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guillaume Nodet (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (FELIX-2201) [FileInstall] Make Scanner process artifacts in "oldest-file-modification-time first" order
Date Mon, 26 Apr 2010 18:39:32 GMT

     [ https://issues.apache.org/jira/browse/FELIX-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Guillaume Nodet reopened FELIX-2201:


The patch applied to fix FELIX-2201 seems to have caused a regression:
See: https://issues.apache.org/jira/browse/FELIX-2201
svn diff -c937979 http://svn.apache.org/repos/asf/felix

The problem is that it keeps a TreeSet of files, ordered by last
modification time.  This causes a problem when more than one file in
the directory has the same modification time.  Say all the files in
the watched directory have the same timestamp: the resulting TreeSet
contains only one element!  (See TreeMap#put(K,V)).

I've read though the mailing list discussion about the issue [1], and
I still don't understand the purpose of the patch.  Specifically, I
don't follow why it's necessary to handle artifacts that "are
basically sets of 'library bundles' that export packages rather than
services" [2].

Maintaining a TreeSet based on a file timestamp doesn't seem like a
good solution:  what happens if the timestamp changes while it is in
the set?  Does the TreeSet then become inconsistent?  It also seems
somewhat heavyweight: how many times do all the files get stat'd to
check their timestamps while building the set?

Because of the regression: I'd like to re-open the bug, if that's OK?
Could the 'fix' be reverted until a better solution can be found?


[1] http://www.mail-archive.com/users@felix.apache.org/msg06949.html
[2] http://www.mail-archive.com/users@felix.apache.org/msg06963.html

> [FileInstall] Make Scanner process artifacts in "oldest-file-modification-time first"
> -------------------------------------------------------------------------------------------
>                 Key: FELIX-2201
>                 URL: https://issues.apache.org/jira/browse/FELIX-2201
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-2.0.4
>            Reporter: Peter GardfjÀll
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-2.0.10
>         Attachments: processing_order_patch.diff
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
> Currently FileInstall does not process new files in the load directory in any particular
> It would be beneficial to have these artifacts processed in a First-Come-First-Served
> That is, in order of increasing file modification time.
> Refer to the following email thread for details
>   http://www.mail-archive.com/users@felix.apache.org/msg06949.html

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message